Bug 278375
| Summary: | Remove Quirk shouldHideSearchFieldResultsButton for *google.* | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | WebKit Misc. | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://google.com | ||
| Bug Depends on: | 223700 | ||
| Bug Blocks: | |||
Karl Dubost
<rdar://75792913>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
1. Open Safari iOS
2. Go to https://www.google.com/
3. Open Safari on macOS
4. Plug your mobile phone to your laptop with a USB cable
5. Develop → Choose the name of your device → Choose www.google.com
3. click on the little icon on the top left inside the Web inspector
4. Choose Disable site specific hacks
Reload the page.
Does it show two magnifiers or only one?
if only one, this is fixed.
I believe in my tests that this is fixed and that we can remove the quirk.
See the code to be removed.
https://searchfox.org/wubkat/search?q=shouldHideSearchFieldResultsButton&path=&case=false®exp=false
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/34685
EWS
Committed 284672@main (124527c205a0): <https://commits.webkit.org/284672@main>
Reviewed commits have been landed. Closing PR #34685 and removing active labels.