Bug 27834

Summary: [commit+] Allow custom memory allocation control for JavaScriptCore's ScopeChain class
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch oliver: review-

Description Zoltan Horvath 2009-07-30 05:49:18 PDT
Inherits ScopeChain class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109.
Comment 1 Zoltan Horvath 2009-07-30 05:51:50 PDT
Created attachment 33774 [details]
proposed patch
Comment 2 Adam Barth 2009-08-01 01:19:54 PDT
Comment on attachment 33774 [details]
proposed patch

Clearing review flag on attachment: 33774

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/ScopeChain.h
Committed r46668
	M	JavaScriptCore/runtime/ScopeChain.h
	M	JavaScriptCore/ChangeLog
r46668 = 90053501e66706eafcc6a1899f728634c387850f (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46668
Comment 3 Adam Barth 2009-08-01 01:19:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Oliver Hunt 2009-08-01 13:21:32 PDT
Comment on attachment 33774 [details]
proposed patch

This patch needs to be rolled out - it was using placement new, ScopeChain is not a heap allocated type.
Comment 5 Oliver Hunt 2009-08-01 13:23:38 PDT
Reopening as it this patch needs to be rolled out - the bug is invalid.
Comment 6 Zoltan Horvath 2009-08-01 13:26:37 PDT
You are right! Thanks for your attention.
Comment 7 Mark Rowe (bdash) 2009-08-01 16:00:46 PDT
Rolled out in r46679.