Bug 278296
| Summary: | Make sure Markable is set when dereferencing it and getting its value | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Make sure WTF::Markable is set when dereferencing it and getting its value, similarly to what is done with std::optional. We currently have no check so you can dereference an unset Markable and get an unexpected value. This matters a lot when using Markable with ObjectIdentifier for example. ObjectIdentifier is expected to be a valid identifier, however, you can easily get can invalid ObjectIdentifier if it was stored in a Markable.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/32363
EWS
Committed 282412@main (1b44f3a2465f): <https://commits.webkit.org/282412@main>
Reviewed commits have been landed. Closing PR #32363 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/134221754>