Bug 27826

Summary: [V8] Remove bug-bait V8Proxy::context()
Product: WebKit Reporter: Adam Barth <abarth>
Component: DOMAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 27703    
Bug Blocks:    
Attachments:
Description Flags
Patch v1
none
Patch v1 none

Adam Barth
Reported 2009-07-29 23:37:35 PDT
The zero-argument version of V8Proxy::context() is never the right way to get the context. We should remove this bug-bait function once we finish removing all the clients. (ScheduledAction is the only remaining client, see Bug 27703).
Attachments
Patch v1 (2.47 KB, patch)
2009-07-29 23:40 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch v1 (2.57 KB, patch)
2009-07-29 23:52 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-07-29 23:40:48 PDT
Created attachment 33760 [details] Patch v1
David Levin
Comment 2 2009-07-29 23:50:08 PDT
Comment on attachment 33760 [details] Patch v1 > Index: WebCore/bindings/v8/V8Proxy.cpp > + v8::Context::Scope contextScope(m_context); This is more than just a transform on this line. This line would be equivalent to what was there before: v8::Context::Scope contextScope(v8::Local<v8::Context>::New(m_context)); So r+ if you make this change to make it equivalent to before.
Adam Barth
Comment 3 2009-07-29 23:52:47 PDT
Created attachment 33761 [details] Patch v1
Adam Barth
Comment 4 2009-07-30 13:44:57 PDT
Assigning to myself while we remove the remaining client.
Adam Barth
Comment 5 2009-08-06 01:27:11 PDT
Comment on attachment 33761 [details] Patch v1 Clearing review flag on attachment: 33761 Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8Proxy.cpp Sending WebCore/bindings/v8/V8Proxy.h Transmitting file data ... Committed revision 46840. http://trac.webkit.org/changeset/46840
Adam Barth
Comment 6 2009-08-06 01:27:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.