Bug 27820

Summary: [commit+] Adding layout test for Unicode in <script> tag attributes
Product: WebKit Reporter: Evan Martin <evan>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
wip
none
patch with changelog none

Evan Martin
Reported 2009-07-29 16:24:24 PDT
Chrome bug here: http://code.google.com/p/chromium/issues/detail?id=17958 This bug is for the regression test.
Attachments
wip (811 bytes, patch)
2009-07-29 16:30 PDT, Evan Martin 		no flags
DetailsFormatted DiffDiff
patch with changelog (1.34 KB, patch)
2009-07-30 13:40 PDT, Evan Martin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Evan Martin
Comment 1 2009-07-29 16:30:12 PDT
Created attachment 33750 [details] wip --- 2 files changed, 10 insertions(+), 0 deletions(-)
Evan Martin
Comment 2 2009-07-29 16:31:55 PDT
Hopefully someone who monitors my bugts here will take pity on me and help me figure out where this test belongs. The interesting part of the call stack of the crash is (WebCore::ScriptElementData::shouldExecuteAsJavaScript const v+0x6e) [0x8d073ae] (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript const v+0x14) [0x930ac34] (WebCore::HTMLTokenizer::scriptHandler(WebCore::HTMLTokenizer::State)+0x237) [0x8dbbe11] Does that count as parser? That's why my patch does.
Evan Martin
Comment 3 2009-07-30 10:19:11 PDT
(Will upload a changelog if the basic idea looks ok -- this is the first layout test I've contributed.)
Adam Barth
Comment 4 2009-07-30 12:46:26 PDT
Comment on attachment 33750 [details] wip Yeah, this looks good. We just need a ChangeLog. WebKitTools/Scripts/prepare-ChangeLog can help you with that.
Evan Martin
Comment 5 2009-07-30 13:40:59 PDT
Created attachment 33831 [details] patch with changelog --- 3 files changed, 20 insertions(+), 0 deletions(-)
Adam Barth
Comment 6 2009-07-30 13:43:28 PDT
Comment on attachment 33831 [details] patch with changelog Awesome! Thanks for the patch.
Adam Barth
Comment 7 2009-08-01 00:23:53 PDT
Comment on attachment 33831 [details] patch with changelog Clearing review flag on attachment: 33831 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/parser/smart-quotes-in-tag-expected.txt A LayoutTests/fast/parser/smart-quotes-in-tag.html Committed r46665 M LayoutTests/ChangeLog A LayoutTests/fast/parser/smart-quotes-in-tag.html A LayoutTests/fast/parser/smart-quotes-in-tag-expected.txt r46665 = 026f80cb444acb568910eac8f412de21cd9dbda5 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46665
Adam Barth
Comment 8 2009-08-01 00:23:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.