Bug 27816

Summary:

WINCE PORT: some files modified for WINCE build

Product:

WebKit

Reporter:

Yong Li <yong.li.webkit>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

manyoso, staikos

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

23154

Attachments:

Description	Flags
the patch	staikos: review-
updated patch	staikos: review-
updatd (PopupMenuWin.cpp)	staikos: review+

Yong Li

Reported 2009-07-29 14:02:42 PDT

WebCore/accessibility/AccessibilityObject.h WebCore/page/win/EventHandlerWin.cpp WebCore/platform/win/BitmapInfo.h WebCore/platform/win/PlatformMouseEventWin.cpp WebCore/platform/win/PlatformScreenWin.cpp WebCore/platform/win/PopupMenuWin.cpp

Attachments
the patch (12.66 KB, patch) 2009-07-29 14:14 PDT, Yong Li	staikos: review-	Details Formatted Diff Diff
updated patch (12.62 KB, patch) 2009-07-29 14:25 PDT, Yong Li	staikos: review-	Details Formatted Diff Diff
updatd (PopupMenuWin.cpp) (9.31 KB, patch) 2009-07-30 07:56 PDT, Yong Li	staikos: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yong Li

Comment 1 2009-07-29 14:14:47 PDT

Created attachment 33741 [details] the patch About BitmapInfo: We started using class BitmapInfo in WINCE port at least 1 year ago. Later, we found that webkit upstream added BitmapInfo.h for win32 port. However, the usage is different. Probably we should restructure it to make WINCE and WIN32 share a same BitmapInfo class? I'm not sure if it's good for win32 port.

Yong Li

Comment 2 2009-07-29 14:25:16 PDT

Created attachment 33743 [details] updated patch

George Staikos

Comment 3 2009-07-29 14:28:58 PDT

Comment on attachment 33741 [details] the patch Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at least one place. > class BitmapInfo: public BITMAPINFO Space missing The changes in ~PopupMenu should probably be submitted separately. They look generic.

George Staikos

Comment 4 2009-07-29 14:29:39 PDT

Comment on attachment 33743 [details] updated patch See previous comments

Yong Li

Comment 5 2009-07-29 14:33:46 PDT

(In reply to comment #3) > (From update of attachment 33741 [details]) > Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at > least one place. > > > > class BitmapInfo: public BITMAPINFO > > Space missing > o.k. > > The changes in ~PopupMenu should probably be submitted separately. They look > generic. there's another generic one (ReleaseDC) :)

Yong Li

Comment 6 2009-07-30 07:56:53 PDT

Created attachment 33780 [details] updatd (PopupMenuWin.cpp)

George Staikos

Comment 7 2009-07-30 11:26:03 PDT

Committed, r46591

Note You need to log in before you can comment on or make changes to this bug.