Summary: | WINCE PORT: some files modified for WINCE build | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yong Li <yong.li.webkit> | ||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | manyoso, staikos | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Other | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 23154 | ||||||||||
Attachments: |
|
Description
Yong Li
2009-07-29 14:02:42 PDT
Created attachment 33741 [details]
the patch
About BitmapInfo: We started using class BitmapInfo in WINCE port at least 1 year ago. Later, we found that webkit upstream added BitmapInfo.h for win32 port. However, the usage is different. Probably we should restructure it to make WINCE and WIN32 share a same BitmapInfo class? I'm not sure if it's good for win32 port.
Created attachment 33743 [details]
updated patch
Comment on attachment 33741 [details] the patch Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at least one place. > class BitmapInfo: public BITMAPINFO Space missing The changes in ~PopupMenu should probably be submitted separately. They look generic. Comment on attachment 33743 [details]
updated patch
See previous comments
(In reply to comment #3) > (From update of attachment 33741 [details]) > Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at > least one place. > > > > class BitmapInfo: public BITMAPINFO > > Space missing > o.k. > > The changes in ~PopupMenu should probably be submitted separately. They look > generic. there's another generic one (ReleaseDC) :) Created attachment 33780 [details]
updatd (PopupMenuWin.cpp)
|