Bug 277900
| Summary: | [CMake] Revamp detection of _Float16 in Linux | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Diego Pino <dpino> |
| Component: | New Bugs | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=277672 https://bugs.webkit.org/show_bug.cgi?id=277972 |
||
Diego Pino
The build of WebKitGTK and WPE started failing in many Linux systems after 281895@main, due to lack of _Float16 support.
https://build.webkit.org/#/builders/1060/builds/2320
Changeset 281937@main fixed partially the detection of _Float16 support for some systems, but it didn't fix it for all. For instance, in the case of the WPE-Linux-ARM64-bit-Release-Debian-Stable-Build bot, the systems has the __FLT16_MANT_DIG__ macro defined but still lacks _Float16 support.
Changeset 281940@main attempted to fix this later case, but it broke the build for non CMake system so the patch was reverted.
This new attempt implements _Float16 support via CMake only for Linux systems, while it leaves the detection via macro flags for other systems that are not Linux.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Diego Pino
Pull request: https://github.com/webkit/webkit/pull/31984
EWS
Committed 282131@main (974b49251d28): <https://commits.webkit.org/282131@main>
Reviewed commits have been landed. Closing PR #31984 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/133707090>