Bug 27786

Summary: [WML] WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument()
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: WebCore Misc.Assignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: manyoso, staikos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20393    
Attachments:
Description Flags
Initial patch manyoso: review+

Nikolas Zimmermann
Reported 2009-07-28 17:09:28 PDT
WML*Element classes mostly implement insertedIntoDocument(), not removedFromDocument(). The only case where this is relevant in WML is error handling. The parsed WML tree fragment is inserted in an XHTML compound error document. This requires removedFromDocument() to be correctly implemented otherwhise we run into trouble (visible when using run-webkit-tests fast/wml --random).
Attachments
Initial patch (19.10 KB, patch)
2009-07-28 17:17 PDT, Nikolas Zimmermann
manyoso: review+
Nikolas Zimmermann
Comment 1 2009-07-28 17:17:20 PDT
Created attachment 33681 [details] Initial patch
Adam Treat
Comment 2 2009-07-28 17:33:25 PDT
Comment on attachment 33681 [details] Initial patch After Niko walked me through it over chat I can't find anything wrong. Drats :)
Nikolas Zimmermann
Comment 3 2009-07-28 17:50:21 PDT
Landed in r46510.
Note You need to log in before you can comment on or make changes to this bug.