| Summary: | WINCE PORT: modified graphics files | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yong Li <yong.li.webkit> | ||||||||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | manyoso, staikos | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Other | ||||||||||||||
| OS: | Other | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 23154 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Yong Li
2009-07-28 13:42:32 PDT
Created attachment 33668 [details]
the patch
Created attachment 33669 [details]
remove an unnecessary line
Comment on attachment 33669 [details]
remove an unnecessary line
A lot of the things conditionally removed in this patch look suspicious to me. Are you sure they're correct?
(In reply to comment #3) > (From update of attachment 33669 [details]) > A lot of the things conditionally removed in this patch look suspicious to me. > Are you sure they're correct? Which things do you mean? I didn't see many things removed. We don't have PlatformGradient. Is it possible to refactor this into a PlatformGradient class that doesn't do any "platform" calls so we still fit within the framework? (In reply to comment #5) > Is it possible to refactor this into a PlatformGradient class that doesn't do > any "platform" calls so we still fit within the framework? Yes. We can leave a void* for it. just a waste of 4 bytes. I'll clean it up Created attachment 33719 [details]
remove unnecessary changes
Created attachment 33731 [details]
add some comments for removed ASSERT
Comment on attachment 33731 [details]
add some comments for removed ASSERT
Still more ifdef than I'd like to see but I think it's ok for now. Unfortunately WinCE doesn't make this easy.
Comment on attachment 33731 [details] add some comments for removed ASSERT > +#if !PLATFORM(WINCE) || PLATFORM(QT) > PlatformGraphicsContext* platformContext() const; > +#endif > + > + const Font& font() const; > + void setFont(const Font&); I think we have a problem here. Why are these unconditionally added? In retrospect I think we need more cleanup. (In reply to comment #10) > (From update of attachment 33731 [details]) > > > +#if !PLATFORM(WINCE) || PLATFORM(QT) > > PlatformGraphicsContext* platformContext() const; > > +#endif > > + > > + const Font& font() const; > > + void setFont(const Font&); > > I think we have a problem here. Why are these unconditionally added? > > In retrospect I think we need more cleanup. Hm... we don't use them. probably it's a garbage from very old revision. I'll do do more cleanup. Created attachment 33777 [details]
more clean up
Committed r46590 |