Bug 277730
| Summary: | Remove Quirk shouldTooltipPreventFromProceedingWithClick for covid.cdc.gov | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | WebKit Misc. | Assignee: | Cameron Laviste <claviste> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ahmad.saleem792, neighsanlo, webkit-bug-importer |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://covid.cdc.gov/covid-data-tracker/#maps_percent-covid-deaths | ||
| Bug Depends on: | 223620 | ||
| Bug Blocks: | |||
Karl Dubost
This Quirk was added by Bug 223620
Steps to check if the quirk is still needed.
1. With Safari on iOS
2. Go to https://covid.cdc.gov/covid-data-tracker/#maps_percent-covid-deaths
3. Connect the device to a computer with macOS
4. Open Safari on the desktop computer
5. On the Develop Menu, Choose to connect to your mobile device to the CDC site
6. A new Web Inspector window is opening for the device
7. On the top left, click on the second icon
8. Choose Compatibility section and check the box in front of "Disable Site Specific Hack"
9. On the mobile device, Reload the page https://covid.cdc.gov/covid-data-tracker/#maps_percent-covid-deaths
10. On the map, touch different states.
Result:
an infobox appears for the state and the touch doesn't navigate away.
It means the issue is fixed.
I have checked on a recent build of iOS 18.
It would be good to have a confirmation by a second person.
The code at
https://github.com/WebKit/WebKit/blob/16b1f218b34090cb7e7f23569bebd49966b7df45/Source/WebCore/page/Quirks.cpp#L234-L245
https://github.com/WebKit/WebKit/blob/16b1f218b34090cb7e7f23569bebd49966b7df45/Source/WebCore/page/ios/ContentChangeObserver.cpp#L153-L154
https://github.com/WebKit/WebKit/blob/16b1f218b34090cb7e7f23569bebd49966b7df45/Source/WebCore/page/Quirks.h#L80
can be removed
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133370179>
Cameron Laviste
Pull request: https://github.com/WebKit/WebKit/pull/32306
EWS
Committed 282600@main (0c854b48442d): <https://commits.webkit.org/282600@main>
Reviewed commits have been landed. Closing PR #32306 and removing active labels.
Brian Patterson
(In reply to Cameron Laviste from comment #2)
> Pull request: https://github.com/WebKit/WebKit/pull/32306 https://sandtrix.io
Useful link