Bug 277672
| Summary: | [JSC] Add JIT support for Float16Array | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> |
| Component: | JavaScriptCore | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=277900 https://bugs.webkit.org/show_bug.cgi?id=277902 |
||
| Bug Depends on: | 277761 | ||
| Bug Blocks: | |||
Yusuke Suzuki
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133271787>
Yusuke Suzuki
Pull request: https://github.com/WebKit/WebKit/pull/31775
EWS
Committed 281895@main (f20f57564cef): <https://commits.webkit.org/281895@main>
Reviewed commits have been landed. Closing PR #31775 and removing active labels.
Diego Pino
After this patch the build for Linux is failing on systems with GCC<12, since _Float16 is not defined for such versions of GCC.
https://build.webkit.org/#/builders/1060/builds/2320
```
/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2204-Build/build/Source/WTF/wtf/Float16.h: In function ‘constexpr float WTF::convertFloat16ToFloat32(uint16_t)’:
/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2204-Build/build/Source/WTF/wtf/Float16.h:59:45: error: ‘_Float16’ was not declared in this scope; did you mean ‘_Float64’?
59 | return static_cast<float>(std::bit_cast<_Float16>(h));
| ^~~~~~~~
| _Float64
```
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/31800
EWS
Committed 281937@main (e2a2805dac3e): <https://commits.webkit.org/281937@main>
Reviewed commits have been landed. Closing PR #31800 and removing active labels.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/31830
EWS
Committed 281940@main (79af63a98ecb): <https://commits.webkit.org/281940@main>
Reviewed commits have been landed. Closing PR #31830 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 277761