Bug 277660
| Summary: | Use an enum class for CSSValue Type | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | zak ridouh <zakr> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | karlcow, webkit-bug-importer, zakr |
| Priority: | P2 | Keywords: | EasyFix, GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
zak ridouh
We should use an enum class for the different types of CSSValues so we don't have to repeat "Class" in every name. We could even use the new `using enum`, so we don't need the identifier in front of each enum.
Relevant files:
https://github.com/WebKit/WebKit/blob/fbf46d69fa4deb0bad4471e749bf2349eb353356/Source/WebCore/css/CSSValue.h#L212
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133256102>
Nathan Solomon
Pull request: https://github.com/WebKit/WebKit/pull/32401
EWS
Committed 283564@main (81dfdabf3b60): <https://commits.webkit.org/283564@main>
Reviewed commits have been landed. Closing PR #32401 and removing active labels.
EWS
Committed 283286.138@safari-7620-branch (9e18fa6b7839): <https://commits.webkit.org/283286.138@safari-7620-branch>
Reviewed commits have been landed. Closing PR #1908 and removing active labels.