Bug 27766

Summary:

Web Inspector: encapsulate ScriptState into the ScriptObject, get rid of InspectorJSONObject

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	dglazkov: review+

Pavel Feldman

Reported 2009-07-28 06:43:18 PDT

Currently, ScriptObject/ScriptArray require ScriptState for any operation on them. InspectorJSONObject is a ScriptObject convenience wrapper that lives is WebCore/inspector and encapsulates ScriptState. Its name is a bit confusing: it is not a real JSONObject, it is just an object that is intended to be stringified. This change encapsulates ScriptState in the ScriptObject itself and gets rid of InspectorJSONObject.

Attachments
patch (52.69 KB, patch) 2009-07-28 06:52 PDT, Pavel Feldman	dglazkov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2009-07-28 06:52:56 PDT

Created attachment 33623 [details] patch

Dimitri Glazkov (Google)

Comment 2 2009-07-28 08:43:56 PDT

Comment on attachment 33623 [details] patch r=me. This limits usefulness of the ScriptObject, but sure makes the code more legible/pretty. In any case, we could always add ScriptObject::setState(ScriptState*) later if we need it.

Pavel Feldman

Comment 3 2009-07-28 09:05:32 PDT

M WebCore/WebCore.pro M WebCore/ChangeLog M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/GNUmakefile.am M WebCore/WebCore.gypi M WebCore/bindings/js/ScriptObject.h M WebCore/bindings/js/ScriptObject.cpp M WebCore/bindings/js/ScriptArray.h M WebCore/bindings/js/ScriptArray.cpp M WebCore/bindings/js/ScriptFunctionCall.cpp M WebCore/bindings/js/ScriptObjectQuarantine.cpp M WebCore/bindings/v8/ScriptObject.h M WebCore/bindings/v8/ScriptObject.cpp M WebCore/bindings/v8/ScriptArray.h M WebCore/bindings/v8/ScriptArray.cpp M WebCore/bindings/v8/ScriptFunctionCall.cpp M WebCore/bindings/v8/ScriptObjectQuarantine.cpp D WebCore/inspector/InspectorJSONObject.cpp D WebCore/inspector/InspectorJSONObject.h M WebCore/inspector/InspectorDOMStorageResource.cpp M WebCore/inspector/InspectorDatabaseResource.cpp M WebCore/inspector/InspectorFrontend.cpp M WebCore/inspector/ConsoleMessage.cpp M WebCore/inspector/InspectorFrontend.h M WebCore/inspector/InspectorResource.cpp M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/WebCoreSources.bkl r46490 = 86e33496b1bb9f675699ccdb697950e607d02c5e (trunk)

Timothy Hatcher

Comment 4 2009-07-28 09:13:00 PDT

Thanks for doing this! InspectorJSONObject was confusing many people…

Note You need to log in before you can comment on or make changes to this bug.