Bug 27735

Summary:

Give a helpful name to JSLock argument

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore JavaScript

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Trivial

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	darin: review+

Alexey Proskuryakov

Reported 2009-07-27 14:25:21 PDT

JSLock lock(false) just means "shut up JavaScriptCore warnings, we are not working with the legacy JSC API shared global context". We should use a named argument instead of a boolean,

Attachments
proposed patch (123.05 KB, patch) 2009-07-27 14:31 PDT, Alexey Proskuryakov	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2009-07-27 14:31:59 PDT

Created attachment 33570 [details] proposed patch

Alexey Proskuryakov

Comment 2 2009-07-27 16:46:38 PDT

Committed <http://trac.webkit.org/projects/webkit/changeset/46431>.

Note You need to log in before you can comment on or make changes to this bug.