Bug 277334
| Summary: | [web-animations] Physical properties should take priority over logical properties | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | graouts, graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tim Nguyen (:ntim)
See css/css-logical/animation-001.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/133278333>
Antoine Quint
In the case of "Physical shorthands win over logical shorthands" we fail to compute the correct style for the blending keyframes under Style::Resolver::styleForKeyframe().
Antoine Quint
It appears the issue is that we're getting the properties in the wrong order under `Style::Builder::applyLogicalGroupProperties()` where CSSPropertyMarginLeft/CSSPropertyMarginRight are processed prior to CSSPropertyMarginInlineStart/CSSPropertyMarginInlineEnd.
Antoine Quint
I expect ElementRuleCollector::addAuthorKeyframeRules() should be in charge of making sure properties are processed in the correct order.
Antoine Quint
Or possibly this should be dealt with under `KeyframeEffect::processKeyframes()` assuming this issue is specific to dealing with keyframes provided through the JS API.
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/32764
EWS
Committed 282815@main (74dcb4aac602): <https://commits.webkit.org/282815@main>
Reviewed commits have been landed. Closing PR #32764 and removing active labels.