Bug 277243
| Summary: | prepare-ChangeLog fails to extract function names from changed files with Windows Perl | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <fujii> |
| Component: | Tools / Tests | Assignee: | Fujii Hironori <fujii> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Fujii Hironori
prepare-ChangeLog is used for prepare-commit-msg.
PS C:\webkit\wb> perl .\Tools\Scripts\prepare-ChangeLog --no-write --only-files --git-commit c78d507eeee2
Running status to find changed, added, or removed files.
Reviewing diff to determine which lines changed.
Extracting affected function names from source files.
fatal: path ''Source\WebCore\style\StyleBuilderConverter.h'' does not exist in 'c78d507eeee2'
fatal: path ''Source\WebCore\style\StyleBuilderConverter.h'' does not exist in 'c78d507eeee2^'
fatal: path ''LayoutTests\svg\zoom\page\transform-origin-and-zoom-expected.html'' does not exist in 'c78d507eeee2'
Use of uninitialized value $first_line in pattern match (m//) at .\Tools\Scripts\prepare-ChangeLog line 734.
fatal: path ''LayoutTests\svg\zoom\page\transform-origin-and-zoom.html'' does not exist in 'c78d507eeee2'
Use of uninitialized value $first_line in pattern match (m//) at .\Tools\Scripts\prepare-ChangeLog line 734.
fatal: path ''Source\WebCore\svg\SVGGraphicsElement.cpp'' does not exist in 'c78d507eeee2'
fatal: path ''Source\WebCore\svg\SVGGraphicsElement.cpp'' does not exist in 'c78d507eeee2^'
Change author: Fujii Hironori <Hironori.Fujii@sony.com>.
* LayoutTests/svg/zoom/page/transform-origin-and-zoom-expected.html: Added.
* LayoutTests/svg/zoom/page/transform-origin-and-zoom.html: Added.
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/svg/SVGGraphicsElement.cpp:
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Fujii Hironori
Pull request: https://github.com/WebKit/WebKit/pull/31373
Fujii Hironori
With above PR, it works as expected.
PS C:\webkit\wb> perl .\Tools\Scripts\prepare-ChangeLog --no-write --only-files --git-commit c78d507eeee2
Running status to find changed, added, or removed files.
Reviewing diff to determine which lines changed.
Extracting affected function names from source files.
Change author: Fujii Hironori <Hironori.Fujii@sony.com>.
* LayoutTests/svg/zoom/page/transform-origin-and-zoom-expected.html: Added.
* LayoutTests/svg/zoom/page/transform-origin-and-zoom.html: Added.
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTransform):
(WebCore::Style::BuilderConverter::convertTranslate):
* Source/WebCore/svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::animatedLocalTransform const):
EWS
Committed 281589@main (feb8501f9c7b): <https://commits.webkit.org/281589@main>
Reviewed commits have been landed. Closing PR #31373 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/132836566>