RESOLVED FIXED277243
prepare-ChangeLog fails to extract function names from changed files with Windows Perl
https://bugs.webkit.org/show_bug.cgi?id=277243
Summary prepare-ChangeLog fails to extract function names from changed files with Win...
Fujii Hironori
Reported 2024-07-28 21:15:00 PDT
prepare-ChangeLog is used for prepare-commit-msg. PS C:\webkit\wb> perl .\Tools\Scripts\prepare-ChangeLog --no-write --only-files --git-commit c78d507eeee2 Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Extracting affected function names from source files. fatal: path ''Source\WebCore\style\StyleBuilderConverter.h'' does not exist in 'c78d507eeee2' fatal: path ''Source\WebCore\style\StyleBuilderConverter.h'' does not exist in 'c78d507eeee2^' fatal: path ''LayoutTests\svg\zoom\page\transform-origin-and-zoom-expected.html'' does not exist in 'c78d507eeee2' Use of uninitialized value $first_line in pattern match (m//) at .\Tools\Scripts\prepare-ChangeLog line 734. fatal: path ''LayoutTests\svg\zoom\page\transform-origin-and-zoom.html'' does not exist in 'c78d507eeee2' Use of uninitialized value $first_line in pattern match (m//) at .\Tools\Scripts\prepare-ChangeLog line 734. fatal: path ''Source\WebCore\svg\SVGGraphicsElement.cpp'' does not exist in 'c78d507eeee2' fatal: path ''Source\WebCore\svg\SVGGraphicsElement.cpp'' does not exist in 'c78d507eeee2^' Change author: Fujii Hironori <Hironori.Fujii@sony.com>. * LayoutTests/svg/zoom/page/transform-origin-and-zoom-expected.html: Added. * LayoutTests/svg/zoom/page/transform-origin-and-zoom.html: Added. * Source/WebCore/style/StyleBuilderConverter.h: * Source/WebCore/svg/SVGGraphicsElement.cpp:
Attachments
Fujii Hironori
Comment 1 2024-07-28 21:29:38 PDT
Fujii Hironori
Comment 2 2024-07-28 21:30:43 PDT
With above PR, it works as expected. PS C:\webkit\wb> perl .\Tools\Scripts\prepare-ChangeLog --no-write --only-files --git-commit c78d507eeee2 Running status to find changed, added, or removed files. Reviewing diff to determine which lines changed. Extracting affected function names from source files. Change author: Fujii Hironori <Hironori.Fujii@sony.com>. * LayoutTests/svg/zoom/page/transform-origin-and-zoom-expected.html: Added. * LayoutTests/svg/zoom/page/transform-origin-and-zoom.html: Added. * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertTransform): (WebCore::Style::BuilderConverter::convertTranslate): * Source/WebCore/svg/SVGGraphicsElement.cpp: (WebCore::SVGGraphicsElement::animatedLocalTransform const):
EWS
Comment 3 2024-07-30 12:52:44 PDT
Committed 281589@main (feb8501f9c7b): <https://commits.webkit.org/281589@main> Reviewed commits have been landed. Closing PR #31373 and removing active labels.
Radar WebKit Bug Importer
Comment 4 2024-07-30 12:53:17 PDT
Note You need to log in before you can comment on or make changes to this bug.