Bug 277206

Summary: [Ruby] Add initial parsing support for ruby-align
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, ntim, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75244    
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2024-07-27 08:06:25 PDT
ssia
Attachments
Patch (19.38 KB, patch)
2024-07-27 08:09 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (31.45 KB, patch)
2024-07-27 13:08 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (33.69 KB, patch)
2024-07-28 17:31 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-07-27 08:09:59 PDT
Created attachment 471982 [details] Patch
alan
Comment 2 2024-07-27 13:08:02 PDT
Created attachment 471985 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2024-07-28 10:18:27 PDT
Comment on attachment 471985 [details] Patch LGTM, you'll want to update LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt as well
Tim Nguyen (:ntim)
Comment 4 2024-07-28 10:20:29 PDT
Comment on attachment 471985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471985&action=review > Source/WebCore/css/CSSProperties.json:5504 > + "status": "in development" We often forget to keep the status up-to-date fwiw, please don't forget to remove it once it's done!
Tim Nguyen (:ntim)
Comment 5 2024-07-28 10:21:04 PDT
Comment on attachment 471985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471985&action=review > COMMIT_MESSAGE:9 > +* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/inheritance-expected.txt: > +* LayoutTests/imported/w3c/web-platform-tests/css/css-ruby/parsing/ruby-align-valid-expected.txt: nit: Changelog needs updating with all the rebaselines
alan
Comment 6 2024-07-28 17:31:02 PDT
Created attachment 471993 [details] [fast-cq]Patch
EWS
Comment 7 2024-07-28 20:04:48 PDT
Committed 281478@main (aa7652f60c38): <https://commits.webkit.org/281478@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471993 [details].
Radar WebKit Bug Importer
Comment 8 2024-07-28 20:05:16 PDT
<rdar://problem/132694293>
Note You need to log in before you can comment on or make changes to this bug.