Bug 277089
| Summary: | [WASM] Prefixed opcodes should be printed in full in code origins and disassembly | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | WebAssembly | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Degazio
Our WASM disassembly and code origins assume that each WASM instruction is identifiable by a single OpType. This hasn't been true for a while, and what this means is whenever we dump the origin for a SIMD or GC or Ext1 opcode, we just dump something like "ExtGC" instead of something more specific. We should pass this information along when it's easily possible to aid in debugging.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/132508220>
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/31239
David Degazio
Example --dumpBBQDisassembly=1 output before:
[ 0x1] ExtSIMD
[ 0x13] ExtSIMD
[ 0x25] ExtSIMD
[ 0x28] ExtSIMD
[ 0x2b] End
...and after:
[ 0x1] V128Const
[ 0x13] V128Const
[ 0x25] F32x4Pmin
[ 0x28] F32x4ExtractLane
[ 0x2b] End
EWS
Committed 281418@main (d898a3cffd9c): <https://commits.webkit.org/281418@main>
Reviewed commits have been landed. Closing PR #31239 and removing active labels.