Bug 27702

Summary:

[Qt] Buildfix on Windows

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
proposed patch	none
proposed patch	hausmann: review+

Csaba Osztrogonác

Reported 2009-07-27 02:11:09 PDT

If building QtWebKit with MinGW-4.4, assembler stop the building, because the inline assembly code below compiled to "call %*dl". The "g" constraint should be "m", because *endPaint is nothing but memory operand, such as *beginPaint in hookedBeginPaint function. WebCore/plugins/win/PluginViewWin.cpp - hookedEndPaint function: asm ("push %2\n" "push %3\n" "call *%4\n" : "=a" (result) : "a" (endPaintSysCall), "g" (lpPaint), "g" (hWnd), "g" (*endPaint) );

Attachments
proposed patch (1.06 KB, patch) 2009-07-27 02:14 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
proposed patch (1.24 KB, patch) 2009-07-27 03:36 PDT, Csaba Osztrogonác	hausmann: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2009-07-27 02:14:39 PDT

Created attachment 33526 [details] proposed patch

Csaba Osztrogonác

Comment 2 2009-07-27 03:36:38 PDT

Created attachment 33530 [details] proposed patch

Simon Hausmann

Comment 3 2009-07-27 03:38:45 PDT

Comment on attachment 33530 [details] proposed patch r=me. Thanks!

Simon Hausmann

Comment 4 2009-07-27 03:39:49 PDT

Landed in r46411

Note You need to log in before you can comment on or make changes to this bug.