| Summary: | [Qt] Buildfix on Windows | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | hausmann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Attachments: |
|
||||||||
Created attachment 33526 [details]
proposed patch
Created attachment 33530 [details]
proposed patch
Comment on attachment 33530 [details]
proposed patch
r=me. Thanks!
|
If building QtWebKit with MinGW-4.4, assembler stop the building, because the inline assembly code below compiled to "call %*dl". The "g" constraint should be "m", because *endPaint is nothing but memory operand, such as *beginPaint in hookedBeginPaint function. WebCore/plugins/win/PluginViewWin.cpp - hookedEndPaint function: asm ("push %2\n" "push %3\n" "call *%4\n" : "=a" (result) : "a" (endPaintSysCall), "g" (lpPaint), "g" (hWnd), "g" (*endPaint) );