[V8] Teach V8Proxy::context about isolated worlds

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Adam Barth]

I've looked through all the clients of V8Proxy::context(Frame*), and they'd all rather call V8DOMWrapper::getWrapperContext(Frame*).  Instead of converting all the call sites, we should just teach V8Proxy::context(Frame*) to retrieve the context of Frame* in the current isolated world.  Patch forthcoming.

[Adam Barth]

Created attachment 33527 [details]
patch

[Adam Barth]

Created attachment 33528 [details]
patch

[Dimitri Glazkov (Google)]

Comment on attachment 33528 [details]
patch

ok. Will this affect performance in any measurable way?

[Adam Barth]

Sending        LayoutTests/ChangeLog
Adding         LayoutTests/http/tests/security/isolatedWorld/document-open-expected.txt
Adding         LayoutTests/http/tests/security/isolatedWorld/document-open.html
Sending        LayoutTests/platform/gtk/Skipped
Sending        LayoutTests/platform/mac/Skipped
Sending        LayoutTests/platform/qt/Skipped
Sending        LayoutTests/platform/win/Skipped
Sending        WebCore/ChangeLog
Sending        WebCore/bindings/v8/ScriptController.cpp
Sending        WebCore/bindings/v8/ScriptObjectQuarantine.cpp
Sending        WebCore/bindings/v8/V8AbstractEventListener.cpp
Sending        WebCore/bindings/v8/V8DOMWrapper.cpp
Sending        WebCore/bindings/v8/V8DOMWrapper.h
Sending        WebCore/bindings/v8/V8Helpers.cpp
Sending        WebCore/bindings/v8/V8LazyEventListener.cpp
Sending        WebCore/bindings/v8/V8Proxy.cpp
Sending        WebCore/bindings/v8/V8Proxy.h
Transmitting file data .................
Committed revision 46523.
http://trac.webkit.org/changeset/46523

[Adam Barth]

(In reply to comment #3)
> ok. Will this affect performance in any measurable way?

It shouldn't, but we'll see from the perf bots.