Bug 276992

Summary: [JSC] Remove dead code for `String#replace` and `String#replaceAll`
Product: WebKit Reporter: Sosuke Suzuki <sosuke>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Sosuke Suzuki
Reported 2024-07-24 04:29:30 PDT
We've added a fast path for `String#replace(string, string)` at https://commits.webkit.org/280990@main. With this addition, whenever the `replaceValue` in `stringReplaceUsingStringSearch` is a string, the fast path is executed. Therefore, the slow path is only reached when `replaceValue` is a function.
Attachments
Sosuke Suzuki
Comment 1 2024-07-24 04:30:25 PDT
EWS
Comment 2 2024-07-29 00:27:41 PDT
Committed 281485@main (ed9c21817325): <https://commits.webkit.org/281485@main> Reviewed commits have been landed. Closing PR #31148 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-07-29 00:28:14 PDT
Note You need to log in before you can comment on or make changes to this bug.