Bug 27695

Summary: There are many DOM Storage corner cases the layout tests don't currently cover.
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 abarth: review+

Description Jeremy Orlow 2009-07-26 21:14:32 PDT
There are many DOM Storage corner cases the layout tests don't currently cover.
Comment 1 Jeremy Orlow 2009-07-26 21:44:23 PDT
Created attachment 33517 [details]
v1

Add some checks to existing layout tests.
Comment 2 Jeremy Orlow 2009-07-26 21:47:11 PDT
Comment on attachment 33517 [details]
v1

Note that almost all of these will have to be done for sessionStorage as well.  It's my intention to do them once this is reviewed.  If it's cleaner, I can do those changes and add it to this patch.  Otherwise I can do them in another patch and just add it to this bug.
Comment 3 Adam Barth 2009-07-28 01:36:26 PDT
Comment on attachment 33517 [details]
v1

Yay tests.  One comment:

+ log("window.sessionStorage == window.sessionStorage: " + (window.sessionStorage == window.sessionStorage));

You should test === too (in both places).
Comment 4 Jeremy Orlow 2009-07-28 13:29:41 PDT
r46498