Bug 276763
| Summary: | http/wpt/mediastream/mediastreamtrackprocessor-videoframe-timestamp.html is flakey | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | youenn fablet <youennf> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
As can be seen in the history, https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fmediastream%2Fmediastreamtrackprocessor-videoframe-timestamp.html, http/wpt/mediastream/mediastreamtrackprocessor-videoframe-timestamp.html is very flakey. This flakiness makes this test actively harmful in EWS, since it can easily fail during one test run and then pass during the clean-build retry.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/131979190>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/30942
EWS
Test gardening commit 281077@main (f06fba7c7937): <https://commits.webkit.org/281077@main>
Reviewed commits have been landed. Closing PR #30942 and removing active labels.
EWS
Test gardening commit 280938.32@safari-7619-branch (c96a0b054eb9): <https://commits.webkit.org/280938.32@safari-7619-branch>
Reviewed commits have been landed. Closing PR #1410 and removing active labels.
youenn fablet
Right, the issue is that becoming an observer requires to hop to main thread.
Either we need to callOnMainThreadAndWait in MediaStreamTrackProcessor::VideoFrameObserverWrapper::start, or we need to allow to call addVideoFrameObserver from any thread, or change the test.
I am inclined to do the first option as a stop gap.
EWS
Committed 281125@main (89195dc481e8): <https://commits.webkit.org/281125@main>
Reviewed commits have been landed. Closing PR #30953 and removing active labels.
EWS
Committed 280938.74@integration/ci/131979190_89195dc481_safari-7619-branch (39ec01e046ea): <https://commits.webkit.org/280938.74@integration/ci/131979190_89195dc481_safari-7619-branch>
Reviewed commits have been landed. Closing PR #1439 and removing active labels.