Bug 276741
| Summary: | Enable JSC_validateOptions on GTK | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Michaud <justin> |
| Component: | JavaScriptCore | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Justin Michaud
Enable JSC_validateOptions on GTK
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Justin Michaud
Pull request: https://github.com/WebKit/WebKit/pull/30925
EWS
Committed 281106@main (e812e22f41af): <https://commits.webkit.org/281106@main>
Reviewed commits have been landed. Closing PR #30925 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/132043022>
Diego Pino
GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 is broken after this patch.
https://build.webkit.org/#/builders/30/builds/9027
The build error is the following:
```
In file included from /home/buildbot/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build/WebKitBuild/GTK/Release/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-f2e18ffc-32.cpp:1:
/home/buildbot/webkitgtk/nightly/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004/build/Source/JavaScriptCore/runtime/Options.cpp:987:27: error: use of undeclared identifier 'environ'
char** envp = environ;
^
```
In Linux, `environ` is an extern variable defined in `unistd.h`.
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/30994
EWS
Committed 281133@main (8e4157809750): <https://commits.webkit.org/281133@main>
Reviewed commits have been landed. Closing PR #30994 and removing active labels.