Bug 276704
| Summary: | Remove legacy MathML pixel test roots.xhtml | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> |
| Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Frédéric Wang (:fredw)
LayoutTests/mathml/presentation/roots.xhtml is the only remaining pixel test from the legacy MathML implementations in WebKit (before 2016).
- This test is really dependent on the system font used, which make it confusing and less robust.
- It contains a lot of mathematical constructions with radicals, but it's difficult to understand what they verify exactly when something breaks (compared to the more modern tests like reftest or testharness.js).
- It breaks quite frequently, and we generally just update the text expectation for the render tree without trying to understand more (the screenshots are often out-of-date).
Consequently it is causing more harm than good, so let's just remove it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang (:fredw)
Pull request: https://github.com/WebKit/WebKit/pull/30895
EWS
Committed 281045@main (7dacb873108c): <https://commits.webkit.org/281045@main>
Reviewed commits have been landed. Closing PR #30895 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/131906021>