WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
276704
Remove legacy MathML pixel test roots.xhtml
https://bugs.webkit.org/show_bug.cgi?id=276704
Summary
Remove legacy MathML pixel test roots.xhtml
Frédéric Wang (:fredw)
Reported
2024-07-16 23:26:19 PDT
LayoutTests/mathml/presentation/roots.xhtml is the only remaining pixel test from the legacy MathML implementations in WebKit (before 2016). - This test is really dependent on the system font used, which make it confusing and less robust. - It contains a lot of mathematical constructions with radicals, but it's difficult to understand what they verify exactly when something breaks (compared to the more modern tests like reftest or testharness.js). - It breaks quite frequently, and we generally just update the text expectation for the render tree without trying to understand more (the screenshots are often out-of-date). Consequently it is causing more harm than good, so let's just remove it.
Attachments
Add attachment
proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1
2024-07-16 23:41:42 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/30895
EWS
Comment 2
2024-07-17 01:31:58 PDT
Committed
281045@main
(7dacb873108c): <
https://commits.webkit.org/281045@main
> Reviewed commits have been landed. Closing PR #30895 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-07-17 01:32:16 PDT
<
rdar://problem/131906021
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug