Bug 27657

Summary:

Add more wince port files

Product:

WebKit

Reporter:

Yong Li <yong.li.webkit>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

krit, manyoso, staikos

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Bug Depends on:

Bug Blocks:

23154

Attachments:

Description	Flags
the patch	none
remove svg/graphics/wince	none
remove the unnecessary platform file in svg/graphics	none

Yong Li

Reported 2009-07-24 08:59:41 PDT

Add new files only

Attachments
the patch (47.27 KB, patch) 2009-07-24 09:09 PDT, Yong Li	no flags	Details Formatted Diff Diff
remove svg/graphics/wince (1.58 KB, patch) 2009-08-06 07:12 PDT, Yong Li	no flags	Details Formatted Diff Diff
remove the unnecessary platform file in svg/graphics (2.10 KB, patch) 2009-08-06 07:16 PDT, Yong Li	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yong Li

Comment 1 2009-07-24 09:09:39 PDT

Created attachment 33454 [details] the patch * loader/icon/wince/IconDatabaseWince.cpp: Added. * rendering/RenderThemeWince.cpp: Added. * rendering/RenderThemeWince.h: Added. * storage/wince/DatabaseThreadWince.cpp: Added. * storage/wince/DatabaseThreadWince.h: Added. * storage/wince/LocalStorageThreadWince.cpp: Added. * storage/wince/LocalStorageThreadWince.h: Added. * svg/graphics/wince/SVGResourceFilterWince.cpp: Added.

George Staikos

Comment 2 2009-07-24 09:31:00 PDT

Comment on attachment 33454 [details] the patch Subject to the following minor corrections: > +++ b/WebCore/loader/icon/wince/IconDatabaseWince.cpp > @@ -0,0 +1,82 @@ > +/* > + * Copyright (C) 2007 Staikos Computing Services Inc. Copyright should be Torch Mobile Inc. Is the year correct? > +#ifndef RenderThemeWincece_h > +#define RenderThemeWincece_h Might want to fix that Rest looks okay to me.

Adam Treat

Comment 3 2009-07-24 14:13:38 PDT

Landed with r46374.

Dirk Schulze

Comment 4 2009-08-06 02:51:31 PDT

This patch crated the folder svg/graphics/wince/ and the file svg/graphics/wince/SVGResourceFilterWince.cpp. All platform dependent code was deleted in svg some months ago. Can someone make a follow up and delete this code?

George Staikos

Comment 5 2009-08-06 06:55:51 PDT

Yes we should do that.

Yong Li

Comment 6 2009-08-06 07:12:37 PDT

Created attachment 34207 [details] remove svg/graphics/wince the file is no longer necessary.

Yong Li

Comment 7 2009-08-06 07:16:45 PDT

Created attachment 34208 [details] remove the unnecessary platform file in svg/graphics

George Staikos

Comment 8 2009-08-06 07:19:48 PDT

Comment on attachment 34208 [details] remove the unnecessary platform file in svg/graphics already landed

George Staikos

Comment 9 2009-08-06 07:20:13 PDT

r46842

Note You need to log in before you can comment on or make changes to this bug.