Bug 276509
| Summary: | Handle 'empty' srcAttr in Media Element | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Media | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, eric.carlson, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar, WPTImpact |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
We fail following WPT tests uniquely.
WPT: https://wpt.fyi/results/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html?label=master&label=experimental&aligned&q=safari%3Afail%20chrome%3Apass%20firefox%3Apass
We need to modify following code: https://searchfox.org/wubkat/rev/80329f1d5c7dfbbb9f782591faecc859d9abf55b/Source/WebCore/html/HTMLMediaElement.cpp#1617
Where we are using `getNonEmptyURLAttribute` to ignore emptyURL, while as per spec, we should not.
https://html.spec.whatwg.org/multipage/media.html#dom-media-currentsrc-dev
> Returns the empty string when there is no media resource, or it doesn't have a URL.
Just raising, so we can track and fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/132042925>
Ahmad Saleem
Pull request: https://github.com/WebKit/WebKit/pull/39567
EWS
Committed 289432@main (dccfae42bb29): <https://commits.webkit.org/289432@main>
Reviewed commits have been landed. Closing PR #39567 and removing active labels.