WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
276509
Handle 'empty' srcAttr in Media Element
https://bugs.webkit.org/show_bug.cgi?id=276509
Summary
Handle 'empty' srcAttr in Media Element
Ahmad Saleem
Reported
2024-07-11 15:25:13 PDT
Hi Team, We fail following WPT tests uniquely. WPT:
https://wpt.fyi/results/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html?label=master&label=experimental&aligned&q=safari%3Afail%20chrome%3Apass%20firefox%3Apass
We need to modify following code:
https://searchfox.org/wubkat/rev/80329f1d5c7dfbbb9f782591faecc859d9abf55b/Source/WebCore/html/HTMLMediaElement.cpp#1617
Where we are using `getNonEmptyURLAttribute` to ignore emptyURL, while as per spec, we should not.
https://html.spec.whatwg.org/multipage/media.html#dom-media-currentsrc-dev
> Returns the empty string when there is no media resource, or it doesn't have a URL.
Just raising, so we can track and fix it. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-07-18 15:26:19 PDT
<
rdar://problem/132042925
>
Ahmad Saleem
Comment 2
2025-01-26 03:57:39 PST
Pull request:
https://github.com/WebKit/WebKit/pull/39567
EWS
Comment 3
2025-01-27 10:43:16 PST
Committed
289432@main
(dccfae42bb29): <
https://commits.webkit.org/289432@main
> Reviewed commits have been landed. Closing PR #39567 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug