Bug 276488
| Summary: | [GTK] Remove GTK 3 comment from GTK 4 web view background color docs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
Alice says this comment only applies to GTK 3 and not GTK 4:
> Note that the parent window must have a RGBA visual and GtkWidget:app-paintable property set to TRUE for backgrounds colors to work.
Unfortunately, maintaining two different versions of the comment is annoying. It's also annoying to write "Do this if using GTK 3" in the GTK 4 version of the documentation. I'm inclined to optimize for GTK 4 and just delete the comment.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Well, actually we already have separate GTK 3 and GTK 4 source files here, so it's not so hard to have two different copies.
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/30700
EWS
Committed 280892@main (2d8800de7fc8): <https://commits.webkit.org/280892@main>
Reviewed commits have been landed. Closing PR #30700 and removing active labels.