Bug 27636

Summary: [Gtk] Add implementation of GCController for DRT
Product: WebKit Reporter: Jan Alonzo <jmalonzo>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch eric: review+

Jan Alonzo
Reported 2009-07-23 21:44:05 PDT
Gtk DRT's GCController is currently missing an implementation. Patch coming to add an impl and enable a couple more test.
Attachments
patch (6.94 KB, patch)
2009-07-23 21:47 PDT, Jan Alonzo 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2009-07-23 21:47:58 PDT
Created attachment 33405 [details] patch
Eric Seidel (no email)
Comment 2 2009-07-23 23:07:25 PDT
Comment on attachment 33405 [details] patch Looks fine. I'm surprised you all don't have a macro for DELETE_AND_ZERO: delete gcController; 689 gcController = 0; The Mac DRT has one for RELEASE_AND_ZERO iirc.
Jan Alonzo
Comment 3 2009-07-23 23:52:36 PDT
(In reply to comment #2) > (From update of attachment 33405 [details]) > Looks fine. > > I'm surprised you all don't have a macro for DELETE_AND_ZERO: > delete gcController; > 689 gcController = 0; > > The Mac DRT has one for RELEASE_AND_ZERO iirc. Hi Eric. Thanks for the r+. Landed as http://trac.webkit.org/changeset/46319. WRT releaseAndZero, it wasn't really needed before as we only had gLayoutTestController to zero. releaseAndZero will probably be handy once we enable more functionality to our DRT. Thanks for bringing it up.
Note You need to log in before you can comment on or make changes to this bug.