Bug 276297
| Summary: | Remove `other` from SFrameTransformErrorEventType interface as per web specification | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | WebRTC | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, youennf |
| Priority: | P2 | Keywords: | EasyFix, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While looking into WebRTC spec, I noticed that we have additional `other` error event type.
Web-Spec: https://w3c.github.io/webrtc-encoded-transform/#enumdef-sframetransformerroreventtype
WebKit Source: https://searchfox.org/wubkat/rev/c994460e362bfdfa5706e5fb55b79eef38f51527/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl#29
___
We need to do following:
In 'IDL' file: https://searchfox.org/wubkat/rev/c994460e362bfdfa5706e5fb55b79eef38f51527/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl#29
Remove `other`
In '.h' file: https://searchfox.org/wubkat/rev/c994460e362bfdfa5706e5fb55b79eef38f51527/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl#29
Remove `other` from enum
In `.cpp` file: https://searchfox.org/wubkat/rev/c994460e362bfdfa5706e5fb55b79eef38f51527/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp#120
Remove:
case RTCRtpSFrameTransformer::Error::Other:
return RTCRtpSFrameTransformErrorEvent::Type::Other;
______
Just raising so we can track and fix it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 280880@main (2124f58f2dae): <https://commits.webkit.org/280880@main>
Reviewed commits have been landed. Closing PR #30646 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/131572447>