Bug 276294

Summary: Remove `overflow: auto` for `textarea` from `StyleAdjuster.cpp`
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: annevk, karlcow, ntim, webkit-bug-importer
Priority: P2 Keywords: BrowserCompat, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: http://wpt.live/html/rendering/non-replaced-elements/form-controls/resets.html
Attachments:
Description Flags
test results in safari, firefox, chromering none

Description Ahmad Saleem 2024-07-06 19:21:11 PDT
Hi Team,

While exploring WPT failures on InterOp 2023, I noticed that we fail one test (also Chrome) for textarea:

http://wpt.live/html/rendering/non-replaced-elements/form-controls/resets.html

> <textarea> - overflow	

and noticed that we have following in `StyleAdjuster.cpp`:

https://searchfox.org/wubkat/rev/426186a23c4afc5565407d381766d9cfb9620156/Source/WebCore/style/StyleAdjuster.cpp#570

Remove this:

// Textarea considers overflow visible as auto.
        if (is<HTMLTextAreaElement>(*m_element)) {
            style.setOverflowX(style.overflowX() == Overflow::Visible ? Overflow::Auto : style.overflowX());
            style.setOverflowY(style.overflowY() == Overflow::Visible ? Overflow::Auto : style.overflowY());
        }

and we progress above but I tried to find reference in HTML WHATWG but couldn't manage to find it.

Thanks!
Comment 1 Ahmad Saleem 2024-07-06 19:24:45 PDT
Strange - for some reason, it makes following pass as well.

wrap-enumerated-ascii-case-insensitive.html
Comment 2 Karl Dubost 2024-07-08 00:08:51 PDT
Created attachment 471838 [details]
test results in safari, firefox, chromering

tested in 
Safari Technology Preview  198           20619.1.20.7
Firefox Nightly            129.0a1       12924.7.4
Google Chrome Canary       128.0.6582.0  6582.0


assert_equals: expected "visible" but got "auto"
@http://wpt.live/html/rendering/support/test-ua-stylesheet.js:34:21
@http://wpt.live/resources/testharness.js:2622:30
test@http://wpt.live/resources/testharness.js:633:34
runUAStyleTests@http://wpt.live/html/rendering/support/test-ua-stylesheet.js:33:10
global code@http://wpt.live/html/rendering/non-replaced-elements/form-controls/resets.html:117:17
Asserts run
Fail	
assert_equals("auto", "visible")
 /html/rendering/support/test-ua-stylesheet.js:34:21
Comment 3 Ahmad Saleem 2024-07-08 13:05:39 PDT
It was added here: https://github.com/WebKit/WebKit/commit/cbc0361bab42fce24473523af0a83c93ba612ce3

33849@main in 2009.
Comment 4 Radar WebKit Bug Importer 2024-07-13 19:22:13 PDT
<rdar://problem/131685655>