|Summary:||WebCore/page/DOMTimer.cpp/h does not conform to style standards|
|Product:||WebKit||Reporter:||Mike Fenton <mifenton>|
|Component:||New Bugs||Assignee:||Adam Barth <abarth>|
|Version:||528+ (Nightly build)|
Description Mike Fenton 2009-07-23 12:39:34 PDT
Comment 1 Mike Fenton 2009-07-23 13:00:09 PDT
Created attachment 33356 [details] Style patch for DOMTimer.cpp/h
Comment 2 Darin Adler 2009-07-23 13:13:22 PDT
Comment on attachment 33356 [details] Style patch for DOMTimer.cpp/h It seems that most of this patch is about stripping trailing whitespace. I didn't know we had a convention that said this was important.
Comment 3 Adam Treat 2009-07-23 13:18:12 PDT
In the absence of (In reply to comment #2) > (From update of attachment 33356 [details]) > It seems that most of this patch is about stripping trailing whitespace. I > didn't know we had a convention that said this was important. In the abscense of other styling errors, maybe not. But in addition to... Why not? They serve no useful purpose and can be distracting in some editors that highlight them.
Comment 4 Mike Fenton 2009-07-23 13:55:12 PDT
This patch does include non-whitespace changes as well as whitespace changes.
Comment 5 Eric Seidel (no email) 2009-07-23 23:12:32 PDT
Comment on attachment 33356 [details] Style patch for DOMTimer.cpp/h I wish XCode would strip whitespace for me. ;) The changes look fine.
Comment 6 Adam Barth 2009-07-23 23:56:07 PDT
Comment 7 Adam Barth 2009-07-24 00:28:55 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/DOMTimer.cpp M WebCore/page/DOMTimer.h Committed r46324 M WebCore/ChangeLog M WebCore/page/DOMTimer.h M WebCore/page/DOMTimer.cpp r46324 = 33c74813d8d1eb35a78b02d4d954b5890c1b7285 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46324