Bug 27602

Summary: Build fix for x86 platforms
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, kevino
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
abarth: review-
proposed patch abarth: review+

Csaba Osztrogonác
Reported 2009-07-23 02:49:12 PDT
If JIT enabled, the original code works. But if JIT disabled and YARR_JIT enabled only, MacroAssembler.h not included in JIT.h because ENABLE(JIT) macro is false, and it causes build fail.
Attachments
proposed patch (1.42 KB, patch)
2009-07-23 02:51 PDT, Csaba Osztrogonác 		abarth: review-
DetailsFormatted DiffDiff
proposed patch (1.47 KB, patch)
2009-07-24 02:10 PDT, Csaba Osztrogonác 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2009-07-23 02:51:45 PDT
Created attachment 33321 [details] proposed patch
Adam Barth
Comment 2 2009-07-24 00:59:22 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/jit/JIT.cpp Committed r46334 M JavaScriptCore/jit/JIT.cpp M JavaScriptCore/ChangeLog r46334 = 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46334
Adam Barth
Comment 3 2009-07-24 01:06:04 PDT
Comment on attachment 33321 [details] proposed patch This breaks the build.
Adam Barth
Comment 4 2009-07-24 01:08:33 PDT
bugzilla requires a comment here.
Csaba Osztrogonác
Comment 5 2009-07-24 02:02:49 PDT
(In reply to comment #3) > This breaks the build. Sorry, it was my fault, because I forgot to delete the last #endif. And during fix it, I found another fix to solve this problem in trunk: http://trac.webkit.org/changeset/46277 I think this fix is not the best solution. You shouldn't include "MacroAssemblerX86Common.h" platform dependent file on all platforms.
Csaba Osztrogonác
Comment 6 2009-07-24 02:10:23 PDT
Created attachment 33414 [details] proposed patch
Adam Barth
Comment 7 2009-07-24 02:21:25 PDT
Comment on attachment 33414 [details] proposed patch This looks like a reasonable modification to the first patch. Thanks.
Adam Barth
Comment 8 2009-07-24 02:24:11 PDT
I'll try to land this again.
Adam Barth
Comment 9 2009-07-24 02:50:44 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/jit/JIT.cpp Committed r46347 M JavaScriptCore/jit/JIT.cpp M JavaScriptCore/ChangeLog r46347 = 61403abcd62556810c09bae95594d7bf1cb41deb (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46347
Note You need to log in before you can comment on or make changes to this bug.