Bug 275941
| Summary: | Add Quirks for skype on iPadMini so the content is fully accessible | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | WebKit Misc. | Assignee: | Karl Dubost <karlcow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://www.skype.com/en/free-conference-call/?cm_mmc=accessurl | ||
Karl Dubost
There is an issue with free skype calls on iPad Mini, where the UI is not fully visible.
With an iPad Mini, in landscape position:
Steps to reproduce:
1. In landscape, navigate to https://www.skype.com/en/free-conference-call/?cm_mmc=accessurl
2. Tap Create a free video call
3. Tap Start call
4. Tap Allow
5. Observe webpage is cut off
One way to solve it is to apply this rule.
This will make the UI scrollable, and usable.
document.querySelector('.app-container .noFocusOutline > div').style.overflowY = 'scroll’
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
<rdar://129048863>
Karl Dubost
A quirk might be doable in the case of iPads using similar Quirks than
void Adjuster::adjustForSiteSpecificQuirks(RenderStyle& style) const {}
https://searchfox.org/wubkat/rev/3402d3c3b3ae0bab3996518d8be3c5d26fb53b16/Source/WebCore/style/StyleAdjuster.cpp#920-974
It needs to be applied to the domain web.skype.com
and with this rule.
document.querySelector('.app-container .noFocusOutline > div').style.overflowY = 'scroll’
Something along with the right list of rules
if (m_document.quirks().needsIPadSkypeOverflowScrollQuirk()) {
// list of rules to target the right element.
// .app-container .noFocusOutline > div
}
Karl Dubost
Pull request: https://github.com/WebKit/WebKit/pull/31203
EWS
Committed 281621@main (390b5198a596): <https://commits.webkit.org/281621@main>
Reviewed commits have been landed. Closing PR #31203 and removing active labels.