Bug 275923
| Summary: | Remove Quirk shouldDisableWritingSuggestionsByDefault once Gmail adopts the 'writingsuggestions' attribute. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Lily Spiniolas <lily_spiniolas> |
| Component: | HTML Editing | Assignee: | Lily Spiniolas <lily_spiniolas> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | karlcow, ntim, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://mail.google.com/ | ||
| Bug Depends on: | 275917 | ||
| Bug Blocks: | |||
Lily Spiniolas
rdar://130624461
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/131079979>
Tim Nguyen (:ntim)
rdar://130624461
Karl Dubost
1. Open Safari
2. Develop → Developer Settings… → Compatibility: Disable Site Specific hacks
3. Go to the website mail.google.com
4. Create a new mail
5. Write text.
Does it work?
if yes, we can remove the Quirk
it means Google is using 'writingsuggestions' attribute.
Lily Spiniolas
It looks like the 'writingsuggestions' attribute has indeed been adopted. Thank you Karl!
Lily Spiniolas
Pull request: https://github.com/WebKit/WebKit/pull/32507
Lily Spiniolas
I was incorrect- the attribute has not been adopted.
Lily Spiniolas
Pull request: https://github.com/WebKit/WebKit/pull/35802
EWS
Committed 285779@main (7729bfb61789): <https://commits.webkit.org/285779@main>
Reviewed commits have been landed. Closing PR #35802 and removing active labels.