Bug 275923

Summary:	Remove Quirk shouldDisableWritingSuggestionsByDefault once Gmail adopts the 'writingsuggestions' attribute.
Product:	WebKit	Reporter:	Lily Spiniolas <lily_n_spiniolas2>
Component:	HTML Editing	Assignee:	Lily Spiniolas <lily_n_spiniolas2>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	karlcow, ntim, webkit-bug-importer, wenson_hsieh
Priority:	P2	Keywords:	GoodFirstBug, InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
URL:	https://mail.google.com/
Bug Depends on:	275917
Bug Blocks:

Description Lily Spiniolas 2024-06-26 15:09:32 PDT

rdar://130624461

Comment 1 Radar WebKit Bug Importer 2024-07-03 15:10:22 PDT Comment hidden (obsolete)

<rdar://problem/131079979>

Comment 2 Tim Nguyen (:ntim) 2024-07-03 16:34:34 PDT

rdar://130624461

Comment 3 Karl Dubost 2024-08-20 19:43:09 PDT

1. Open Safari
2. Develop → Developer Settings… → Compatibility: Disable Site Specific hacks
3. Go to the website mail.google.com 
4. Create a new mail
5. Write text.

Does it work?

if yes, we can remove the Quirk
it means Google is using 'writingsuggestions' attribute.

Comment 4 Lily Spiniolas 2024-08-20 21:17:05 PDT

It looks like the 'writingsuggestions' attribute has indeed been adopted. Thank you Karl!

Comment 5 Lily Spiniolas 2024-08-20 21:19:34 PDT

Pull request: https://github.com/WebKit/WebKit/pull/32507

Comment 6 Lily Spiniolas 2024-08-20 21:38:15 PDT

I was incorrect- the attribute has not been adopted.

Comment 7 Lily Spiniolas 2024-10-28 11:16:43 PDT

Pull request: https://github.com/WebKit/WebKit/pull/35802

Comment 8 EWS 2024-10-28 12:12:32 PDT

Committed 285779@main (7729bfb61789): <https://commits.webkit.org/285779@main>

Reviewed commits have been landed. Closing PR #35802 and removing active labels.