Bug 275795
| Summary: | Split makeString() and friends out into their own header | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> |
| Component: | Web Template Framework | Assignee: | Diego Pino <dpino> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dpino, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Weinig
Split makeString() and friends out into their own header. This is a prerequisite for adding support for for inverleave to makeString, since it will have to depend on StringBuilder, which would cause a cycle otherwise.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Weinig
Pull request: https://github.com/WebKit/WebKit/pull/30097
Radar WebKit Bug Importer
<rdar://problem/130853488>
EWS
Committed 280586@main (632f10381f7b): <https://commits.webkit.org/280586@main>
Reviewed commits have been landed. Closing PR #30097 and removing active labels.
Diego Pino
Bot 'WPE-Linux-64-bit-Debug-Build' is failing after this change with the following build error:
https://build.webkit.org/#/builders/66/builds/32912
```
/app/webkit/Source/WebCore/PAL/pal/unix/LoggingUnix.cpp:45:16: error: ‘makeString’ was not declared in this scope
45 | return makeString("NotYetImplemented,"_s, span(logEnv));
| ^~~~~~~~~~
```
Diego Pino
Re-opening for pull request https://github.com/webkit/webkit/pull/30420
EWS
Committed 280602@main (4c22854bbd8d): <https://commits.webkit.org/280602@main>
Reviewed commits have been landed. Closing PR #30420 and removing active labels.