| Summary: | [CSS3 Backgrounds and Borders] Add support for the "round" value for background-repeat | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, eric | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 27569 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dave Hyatt
2009-07-22 15:40:48 PDT
Created attachment 38397 [details]
Patch for the CSS part of round and space
Here is a patch for the CSS part of this task. Dan will take on the rendering side later.
Comment on attachment 38397 [details] Patch for the CSS part of round and space This patch makes EFillRepeat values require 3 bits, but does not update the size of the m_repeat member of FillLayer, so assigning to it will clobber the m_composite member. Thus I’m r-’ing. Given bug 28635, I think it will no longer make sense to capture all 16 possible combinations of no-repeat/repeat/space/round with one enum. Instead, I think you should split m_repeat into two fields, one for horizontal repeat and one for vertical repeat. Perhaps you should fix bug 28635 first. Then adding space/round will be simple again (as simple as this patch). Created attachment 38409 [details]
Updated patch
Here is a new patch that fixes the bit field issue in FillLayer.h.
Since this patch is ready to go, I would really rather commit it now than wait until after I fix the 2-keywords bug only to rewrite this patch. That one is next though!
|