Bug 275687
| Summary: | [Win] refactoring on WebPopupMenuProxyWin height and width calculation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kohei Asano <kohei.asano> |
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Windows 10 | ||
Kohei Asano
popupWindowBoarderWidth is no longer constant, calculated via AdjustWindowRectEx as we see https://github.com/WebKit/WebKit/blob/b6d3b63a9d78fcbc286ac2c6e72a8d94c2b8c218/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp#L379-L380.
Also it's better for maintaining to make the flow of calculatePositionAndSize https://github.com/WebKit/WebKit/blob/b6d3b63a9d78fcbc286ac2c6e72a8d94c2b8c218/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp#L351-L441 tidy.
We can do like
1. Initialization
2. Adjust Height/Y
3. Adjust Width/X
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kohei Asano
Pull request: https://github.com/WebKit/WebKit/pull/30140
EWS
Committed 280361@main (d860f938ff53): <https://commits.webkit.org/280361@main>
Reviewed commits have been landed. Closing PR #30140 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/130558832>