RESOLVED FIXED275687
[Win] refactoring on WebPopupMenuProxyWin height and width calculation 
https://bugs.webkit.org/show_bug.cgi?id=275687
Summary [Win] refactoring on WebPopupMenuProxyWin height and width calculation
Kohei Asano
Reported 2024-06-20 07:10:16 PDT
popupWindowBoarderWidth is no longer constant, calculated via AdjustWindowRectEx as we see https://github.com/WebKit/WebKit/blob/b6d3b63a9d78fcbc286ac2c6e72a8d94c2b8c218/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp#L379-L380. Also it's better for maintaining to make the flow of calculatePositionAndSize https://github.com/WebKit/WebKit/blob/b6d3b63a9d78fcbc286ac2c6e72a8d94c2b8c218/Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp#L351-L441 tidy. We can do like 1. Initialization 2. Adjust Height/Y 3. Adjust Width/X
Attachments
Add attachment proposed patch, testcase, etc.
Kohei Asano
Comment 1 2024-06-25 01:13:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/30140
EWS
Comment 2 2024-06-25 21:06:40 PDT
Committed 280361@main (d860f938ff53): <https://commits.webkit.org/280361@main> Reviewed commits have been landed. Closing PR #30140 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-06-25 21:07:14 PDT
<rdar://problem/130558832>
Note You need to log in before you can comment on or make changes to this bug.