Bug 275575
| Summary: | Make WeakPtr to Nodes thread safe again | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andresg_22, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Make WeakPtr to Nodes thread safe again. This shows as performance neutral on the benchmarks we track. The idea was to make the WeakPtrImpl ref count thread safe so that it we could use WeakPtr<Node> in more places, where performance is critical. However, this didn't work out and we plan to use CheckedPtr<Node> for those cases instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/29903
EWS
Committed 280097@main (1c010c13ad37): <https://commits.webkit.org/280097@main>
Reviewed commits have been landed. Closing PR #29903 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/130036850>