Bug 275531
| Summary: | [results.webkit.org] ⌘F should not override system find-in-page if the search panel is collapsed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> |
| Component: | Tools / Tests | Assignee: | Wenson Hsieh <wenson_hsieh> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Wenson Hsieh
It's sometimes useful to have the ability to invoke system find-in-page to quickly reveal text on the page (like certain build trains). However, even when the search panel is collapsed (and the search input is disabled), ⌘F still attempts to focus the disabled commit search field while overriding the built-in find-in-page functionality.
It would be a bit better to defer to the system in this case, so that when the commit search panel is collapsed, the user is able to find text on the page.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Wenson Hsieh
Pull request: https://github.com/WebKit/WebKit/pull/29860
EWS
Committed 280092@main (3fecce8a9b38): <https://commits.webkit.org/280092@main>
Reviewed commits have been landed. Closing PR #29860 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/130034672>