Bug 27553

Summary: Fix cpplint generating false positives for "primary" includes in headers
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: manyoso
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Fix cpplint generating false positives for "primary" includes in headers manyoso: review+

Jakob Petsovits
Reported 2009-07-22 12:32:26 PDT
The following piece of code placed in a header file will incorrectly throw an error: (in "FooBar.h":) #include "Foo.h" Which is because Foo.h is classified as primary include, and thus considered the same by the don't-include-yourself check for header files. That's a false positive, and should be fixed. Patch follows below!
Attachments
Fix cpplint generating false positives for "primary" includes in headers (3.29 KB, patch)
2009-07-22 12:44 PDT, Jakob Petsovits 		manyoso: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2009-07-22 12:44:41 PDT
Created attachment 33283 [details] Fix cpplint generating false positives for "primary" includes in headers
Adam Treat
Comment 2 2009-07-22 12:51:58 PDT
Landed with r46231.
Note You need to log in before you can comment on or make changes to this bug.