Bug 275370
| Summary: | [commits.webkit.org] Correctly classify origin commits in hook | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
On commits.webkit.org, commits from origin aren't correctly classified because the origin push remote is INVALID. This is a non-standard setup because we don't want commits.webkit.org to be able to push content. This ends up classifying all commits from github.com/WebKit/WebKit as "secure" in our pre-push hook, which isn't correct.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/129617235>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/29722
EWS
Committed 279923@main (149ccc3d4b3c): <https://commits.webkit.org/279923@main>
Reviewed commits have been landed. Closing PR #29722 and removing active labels.