Bug 275321
| Summary: | [CMake] Allow using a system-provided libsysprof-capture package | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 275203 | ||
| Bug Blocks: | 277626, 277627, 278341 | ||
Adrian Perez
The patch for bug #275203 imported a copy of the libsysprof-capture
library, but some (although not all) Linux distributions provide a
package for it. It would be friendlier towards packagers to allow
opting out of using the bundled copy. This will need adding a new
CMake find-module for the “sysprof-capture-4” pkg-config module and
using that instead depending on the value of a CMake option. As long
as the find-module defines a SysProfCapture::SysProfCapture target
(as does the bundled copy) then this should imply almost no changes
to the existing CMake files.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/29707
EWS
Committed 282340@main (9cdef20e38c0): <https://commits.webkit.org/282340@main>
Reviewed commits have been landed. Closing PR #29707 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/134030042>