Bug 275174
Summary: | The URL for Chromium bugs has changed, stopping them from being added to See Also in Bugzilla | ||
---|---|---|---|
Product: | WebKit | Reporter: | Daniel Jacobs <danielhunterjacobs> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ap, jond, karlcow, lingho, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | Safari 17 | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Daniel Jacobs
https://bugs.chromium.org/p/chromium/issues/list is now https://issues.chromium.org/issues, but that is not an accepted URL for adding bugs to See Also.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Daniel Jacobs
This change was documented in https://developer.chrome.com/blog/chromium-issue-tracker-migration-complete
Alexey Proskuryakov
Thank you for the report!
The fix would be in Websites/bugs.webkit.org/Bugzilla/BugUrl/Chromium.pm
Daniel Jacobs
Maybe the subroutines in https://github.com/WebKit/WebKit/blob/main/Websites/bugs.webkit.org/Bugzilla/BugUrl/Chromium.pm should just be these, adapted from the simpler code in https://github.com/WebKit/WebKit/blob/main/Websites/bugs.webkit.org/Bugzilla/BugUrl/Google.pm. Though if there's still a desire to support the old Chromium URL syntax the code would either need to be more complex or these subroutines could be added to a new Perl module. I just don't understand the point of the current code for Chromium that gets $project_name and $bug_id in _check_value.
sub should_handle {
my ($class, $uri) = @_;
# Chromium URLs have this form:
# http(s)://issues.chromium.org/issues/1234
return (lc($uri->authority) eq 'issues.chromium.org'
and $uri->path =~ m|^/issues/\d+$| ? 1 : 0;
}
sub _check_value {
my ($class, $uri) = @_;
$uri = $class->SUPER::_check_value($uri);
return $uri;
}
Karl Dubost
is there a chance that old URI will go 500 in the future or 410 Gone?
Asking because I wonder if the bugs should be updated.
Daniel Jacobs
Opened https://github.com/WebKit/WebKit/pull/29624
EWS
Committed 279863@main (15c7ae209695): <https://commits.webkit.org/279863@main>
Reviewed commits have been landed. Closing PR #29624 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/129473435>