Bug 275153

Summary: Limit the number of repaint candidates after simplified layout
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
[fast-cq]Patch none

alan
Reported 2024-06-05 05:16:22 PDT
ssia
Attachments
Patch (9.27 KB, patch)
2024-06-05 05:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.31 KB, patch)
2024-06-05 10:22 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (12.70 KB, patch)
2024-06-05 15:18 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.47 KB, patch)
2024-06-05 21:14 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.97 KB, patch)
2024-06-06 07:33 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (17.37 KB, patch)
2024-06-06 20:39 PDT, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (17.37 KB, patch)
2024-06-07 10:22 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2024-06-05 05:19:15 PDT
Created attachment 471591 [details] Patch
alan
Comment 2 2024-06-05 10:22:16 PDT
Created attachment 471595 [details] Patch
alan
Comment 3 2024-06-05 15:18:18 PDT
Created attachment 471597 [details] Patch
alan
Comment 4 2024-06-05 21:14:21 PDT
Created attachment 471599 [details] Patch
alan
Comment 5 2024-06-06 07:33:55 PDT
Created attachment 471610 [details] Patch
Simon Fraser (smfr)
Comment 6 2024-06-06 14:11:59 PDT
Comment on attachment 471610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471610&action=review > Source/WebCore/page/LocalFrameViewLayoutContext.h:190 > + unsigned m_layoutIdentifier : 11 { 0 }; Let's use a type for LayoutIdentifier > Source/WebCore/rendering/RenderElement.h:409 > + unsigned m_layoutIdentifier : 11 { 0 }; Maybe we should just eat up 16 or 32 bits (shuffling things around if necessary). > Source/WebCore/rendering/RenderLayer.cpp:1025 > + return renderer().layoutIdentifier() == renderer().view().frameView().layoutContext().layoutIdentifier(); Think about putting this in a helper on RenderElement.
alan
Comment 7 2024-06-06 20:39:45 PDT
Created attachment 471615 [details] Patch
alan
Comment 8 2024-06-07 10:22:48 PDT
Created attachment 471621 [details] [fast-cq]Patch
EWS
Comment 9 2024-06-07 18:33:50 PDT
Committed 279847@main (4a5b56e32671): <https://commits.webkit.org/279847@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471621 [details].
Radar WebKit Bug Importer
Comment 10 2024-06-07 18:34:15 PDT
<rdar://problem/129428778>
Note You need to log in before you can comment on or make changes to this bug.