Bug 275134
| Summary: | Enable GraphicsContext filters for Canvas filter | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Canvas | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, sabouhallawa, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Said Abou-Hallawa
GraphicsContext filters were disabled for the canvas filter in 278000@main. The canvas drop-shadow filter was drawn upside down. So software filters were used instead to make the layout test pass.
It turned out all we need is to flip the sign of the vertical offset of the drop-shadow. This is what CanvasRenderingContext2DBase::applyShadow() does when it sets GraphicsContext drop-shadow by calling:
c->setDropShadow({ { width, -height }, state().shadowBlur, state().shadowColor, ShadowRadiusMode::Legacy });
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/129249264>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/29522
EWS
Committed 280195@main (8e66e149a07d): <https://commits.webkit.org/280195@main>
Reviewed commits have been landed. Closing PR #29522 and removing active labels.